Support *all* conf keys in publishConfig #2066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a flatOptions.flatten() method, which takes an object full of config keys, and turns it into an options object. This method expects an object that already inherits from npm's defaults, and is thus expected to be internal only. This commit also removes some config keys which were used by npm dependencies at the start of the v7 beta process, but are no longer: - all lockfile configs (since we don't use lockfiles any more! for anything! and good riddance, they're a rats' nest of race conditions) - cacheMax/cacheMin (we only use preferOffline/offline/online now, so these are strictly legacy support as input and never shared with deps) Once this lands in cli, we can remove the publishConfig handling logic in npm-registry-fetch, as it will be redundant.
darcyclarke
added
Release 7.x
isaacs
added a commit
to npm/npm-registry-fetch
that referenced
this pull request
Oct 28, 2020
Note: SemVer Major breaking change This removes the 'publishConfig' option, as it will no longer be used once npm/cli#2066 lands.
isaacs
added a commit
to npm/npm-registry-fetch
that referenced
this pull request
Oct 28, 2020
Note: SemVer Major breaking change This removes the 'publishConfig' option, as it will no longer be used once npm/cli#2066 lands.
darcyclarke
added
release: next
nlf
pushed a commit
to npm/npm-registry-fetch
that referenced
this pull request
Nov 3, 2020
Note: SemVer Major breaking change This removes the 'publishConfig' option, as it will no longer be used once npm/cli#2066 lands. PR-URL: #36 Credit: @isaacs Close: #36 Reviewed-by: @nlf
|
Landed in 7.0.8 |
|
landed in 6cd3cd0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flatOptions.flatten() method, which takes an object full of
config keys, and turns it into an options object. This method expects
an object that already inherits from npm's defaults, and is thus
expected to be internal only.
This commit also removes some config keys which were used by npm
dependencies at the start of the v7 beta process, but are no longer:
anything! and good riddance, they're a rats' nest of race conditions)
these are strictly legacy support as input and never shared with deps)
Once this lands in cli, we can remove the publishConfig handling logic
in npm-registry-fetch, as it will be redundant.
References