Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knownBroken version #165

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Update knownBroken version #165

merged 2 commits into from
Mar 19, 2019

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 19, 2019

As I've documented here in nvm install-latest-npm, the last version of npm that works on node < v6 is npm v5 - npm v6+ requires node 6.

As I've documented [here](https://github.com/creationix/nvm/blob/master/nvm.sh#L237) in `nvm install-latest-npm`, the last version of `npm` that works on node < v6 is npm v5 - npm v6+ requires node 6.
@ljharb ljharb requested a review from a team as a code owner February 19, 2019 06:57
@zkat zkat added the semver:patch semver patch level for changes label Feb 19, 2019
@zkat
Copy link
Contributor

zkat commented Feb 19, 2019

What breaks with npm@6?

@ljharb
Copy link
Contributor Author

ljharb commented Feb 19, 2019

Unfortunately I didn't document it in my commit message, but local testing indicates:

nvm install 5
npm install -g [email protected]
…
$ npm ls
$HOME/.nvm/versions/node/v5.11.1/lib/node_modules/npm/bin/npm-cli.js:79
      let notifier = require('update-notifier')({pkg})
      ^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

Adding 'use strict' to all files would address this as well.

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it breaks after all! Thanks for the PR, we'll be including it in a release soon. 👍 🐑 🚀 💥

@aeschright aeschright changed the base branch from latest to release-next March 19, 2019 18:20
@aeschright aeschright merged commit 6b1a9da into npm:release-next Mar 19, 2019
@ljharb ljharb deleted the patch-2 branch March 19, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants