Skip to content

Commit

Permalink
Make OK more consistent
Browse files Browse the repository at this point in the history
PR-URL: #241
Credit: @gemal
Close: #241
Reviewed-by: @isaacs
  • Loading branch information
gemal authored and isaacs committed Oct 8, 2019
1 parent f46edae commit 70f54dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/doctor/check-ping.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function checkPing (cb) {
if (err && err.code && err.code.match(/^E\d{3}$/)) {
return cb(null, [err.code.substr(1)])
} else {
cb(null, [200, 'OK'])
cb(null, [200, 'ok'])
}
})
}
Expand Down
4 changes: 2 additions & 2 deletions test/tap/doctor.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ t.test('npm doctor', function (t) {
npm.commands.doctor({'node-url': node_url}, true, function (e, list) {
t.ifError(e, 'npm loaded successfully')
t.same(list.length, 9, 'list should have 9 prop')
t.same(list[0][1], 'OK', 'npm ping')
t.same(list[0][1], 'ok', 'npm ping')
t.same(list[1][1], 'v' + npm.version, 'npm -v')
t.same(list[2][1], process.version, 'node -v')
t.same(list[3][1], common.registry + '/', 'npm config get registry')
Expand All @@ -113,7 +113,7 @@ t.test('npm doctor works without registry', function (t) {
npm.commands.doctor({'node-url': node_url}, true, function (e, list) {
t.ifError(e, 'npm loaded successfully')
t.same(list.length, 9, 'list should have 9 prop')
t.same(list[0][1], 'OK', 'npm ping')
t.same(list[0][1], 'ok', 'npm ping')
t.same(list[1][1], 'v' + npm.version, 'npm -v')
t.same(list[2][1], process.version, 'node -v')
t.same(list[3][1], '', 'no registry, but no crash')
Expand Down

0 comments on commit 70f54dc

Please sign in to comment.