Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

deep reify local links #44

Merged
merged 4 commits into from
Feb 7, 2020
Merged

deep reify local links #44

merged 4 commits into from
Feb 7, 2020

Commits on Feb 5, 2020

  1. Tests for link metadeps, external links, internal links

    @isaacs
    isaacs committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    fc1382d View commit details
    Browse the repository at this point in the history

  2. Handle link deps properly in ideal/virtual/reify 

    Fix: #43

This fixes the bug identified by npm/cli#750

Link deps that point to a location underneath the root package are fully
resolved and reified.  Links external to the root path are left alone,
because they exist in a different project and presumably have their own
dep resolution being done separately.
    @isaacs
    isaacs committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ec3884b View commit details
    Browse the repository at this point in the history

  3. Set resolved property properly on Link nodes 

    Should be the relative path from the link's containing folder, not from
the link path itself.  Ie, it should be the actual argument passed to
fs.symlink() if one were to try to reify the Link node.

This changes a lot of snapshots, but the only one that's really relevant
is the handling in the YarnLock class, since all the other instances of
using consistentResolve to re-relativize a path were handling Link nodes
specially anyway (eg, in reify, shrinkwrap, etc.)
    @isaacs
    isaacs committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    3072abf View commit details
    Browse the repository at this point in the history

  4. Filter fsevents out of snapshots so Travis doesn't fail 

    The reify() method now returns the *actual* actualTree, so even though
engine-mismatching optional deps remain in the package-lock, they're not
being passed in the resolved tree.

Filter the offending darwin-only module out of the snapshots so that Travis
(which is Linux) doesn't fail tests.  In that case, just manually verify that
fsevents is actually in the package-lock, even though it isn't in the snapshot.
    @isaacs
    isaacs committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    eb03ee9 View commit details
    Browse the repository at this point in the history