Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Commit

Permalink
Filter fsevents out of snapshots so Travis doesn't fail
Browse files Browse the repository at this point in the history
The reify() method now returns the *actual* actualTree, so even though
engine-mismatching optional deps remain in the package-lock, they're not
being passed in the resolved tree.

Filter the offending darwin-only module out of the snapshots so that Travis
(which is Linux) doesn't fail tests.  In that case, just manually verify that
fsevents is actually in the package-lock, even though it isn't in the snapshot.
  • Loading branch information
isaacs committed Feb 5, 2020
1 parent 3072abf commit dcb698a
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 12,039 deletions.
4 changes: 2 additions & 2 deletions lib/arborist/reify.js
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ module.exports = cls => class Reifier extends Ideal(cls) {
[_checkEngineAndPlatform] (node) {
// engine/platform checks throw, so start the promise chain off first
return Promise.resolve()
.then(() => this[_checkEngine](node))
.then(() => this[_checkPlatform](node))
.then(() => this[_checkEngine](node))
.then(() => this[_checkPlatform](node))
}


Expand Down
Loading

0 comments on commit dcb698a

Please sign in to comment.