Skip to content

Fix PgTableValuedFunctionExpression cloning #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Fix PgTableValuedFunctionExpression cloning #3026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/EFCore.PG/Query/Expressions/Internal/PgTableValuedFunctionExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ namespace Npgsql.EntityFrameworkCore.PostgreSQL.Query.Expressions.Internal;
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </para>
/// </remarks>
public class PgTableValuedFunctionExpression : TableValuedFunctionExpression, IEquatable<PgTableValuedFunctionExpression>
public class PgTableValuedFunctionExpression : TableValuedFunctionExpression,
IEquatable<PgTableValuedFunctionExpression>, IClonableTableExpressionBase
{
/// <summary>
/// The name of the column to be projected out from the <c>unnest</c> call.
Expand Down Expand Up @@ -80,6 +81,12 @@ public override PgTableValuedFunctionExpression Update(IReadOnlyList<SqlExpressi
? new PgTableValuedFunctionExpression(Alias, Name, arguments, ColumnInfos, WithOrdinality)
: this;

// TODO: This is a hack for https://github.com/npgsql/efcore.pg/issues/3023; we notably don't visit the arguments, which we should
// (but can't, since the Clone() API doesn't accept the cloning visitor).
/// <inheritdoc />
public TableExpressionBase Clone()
=> new PgTableValuedFunctionExpression(Alias, Name, Arguments, ColumnInfos, WithOrdinality);

/// <inheritdoc />
protected override void Print(ExpressionPrinter expressionPrinter)
{
Expand Down