Turn on API consistency tests #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Apr 28, 2020
AndriySvyryd
approved these changes
Apr 28, 2020
YohDeadfall
approved these changes
Apr 29, 2020
Good question :) Annotating the EF Core public API itself is tracked by dotnet/efcore#14150, and we're not sure we'll have time to do it for 5.0. Without annotating the EF Core APIs, it makes no sense to annotate only EFCore.PG (annotation should happen bottom-up). Even when we do C# NRT annotations, the plan is to still keep the Jetbrains annotations - at least for a while - for people not yet using the new NRT feature. In any case, the Jetbrains annotation are like a first step - they will make it easier to annotate with the built-in ones later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the upstream API consistency tests, and corrects many small issues. There are some extremely minor breaking changes on APIs that users are never expected to use, and no behavioral changes.
Note: this PR is based off of #1353