Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

No error when method telegram is unavailable #88

Closed
sveeke opened this issue Sep 6, 2019 · 1 comment
Closed

No error when method telegram is unavailable #88

sveeke opened this issue Sep 6, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sveeke
Copy link
Contributor

sveeke commented Sep 6, 2019

No breaking bug or anything, but since the check for METHOD_TELEGRAM is simply whether serverbot.conf is available, the user can use method telegram while it won't work at all.

@sveeke sveeke added the bug Something isn't working label Sep 6, 2019
@sveeke sveeke self-assigned this Sep 6, 2019
@sveeke sveeke added this to the Q3-2019 milestone Sep 6, 2019
sveeke referenced this issue Sep 11, 2019
- Added error when method telegram is not configured https://github.com/nozel-org/serverbot/issues/88.
- Added notification to user on serverbot upgrade https://github.com/nozel-org/serverbot/issues/84.
- Made some preperations for method email.
- Made some clarifications in comments.
@sveeke
Copy link
Contributor Author

sveeke commented Sep 11, 2019

Fixed in nozel-org/serverbot@0726361.

@sveeke sveeke closed this as completed Sep 11, 2019
sveeke added a commit that referenced this issue Sep 24, 2019
This is a combined update for all `1.1.0-UNSTABLE` commits.
- Changed suffixes from `ALPHA`, `BETA` and `RELEASE` to new suffix layout `UNSTABLE` and `STABLE`.
- Added feature EOL #63.
- Added basic configuration file parameter validation #83.
- Added notification to user on serverbot upgrade #84.
- Removed abundance of comments that weren't very useful #85.
- Added error when method telegram is not configured #88.
- Made all gather functions calls consistent by placing them inside relevant functions #89.
- Added branch variable in serverbot #90.
- Removed argument shortcuts because of conflicting names #92.
- Removed useless breaks in feature updates method cli #93.
- Improved validation of serverbot.conf to accomodate new features in minor releases better #96.
- Ignore dots in variables for feature eol #97.
- Fixed bug that replaced a variable in serverbot.conf with only the first character of the source variable #99.
- Changed variable when no serverbot.conf is available to be more clear.
- Some minor text improvements across all files and comments.
- Removed placeholders for planned features.
- Made some preparations for method email.
- Changed some default values in serverbot.conf to have less overlap.
sveeke added a commit that referenced this issue Sep 24, 2019
This is a combined update for all `1.1.0-UNSTABLE` commits.
- Changed suffixes from `ALPHA`, `BETA` and `RELEASE` to new suffix layout `UNSTABLE` and `STABLE`.
- Added feature EOL #63.
- Added basic configuration file parameter validation #83.
- Added notification to user on serverbot upgrade #84.
- Removed abundance of comments that weren't very useful #85.
- Added error when method telegram is not configured #88.
- Made all gather functions calls consistent by placing them inside relevant functions #89.
- Added branch variable in serverbot #90.
- Removed argument shortcuts because of conflicting names #92.
- Removed useless breaks in feature updates method cli #93.
- Improved validation of serverbot.conf to accomodate new features in minor releases better #96.
- Ignore dots in variables for feature eol #97.
- Fixed bug that replaced a variable in serverbot.conf with only the first character of the source variable #99.
- Changed variable when no serverbot.conf is available to be more clear.
- Some minor text improvements across all files and comments.
- Removed placeholders for planned features.
- Made some preparations for method email.
- Changed some default values in serverbot.conf to have less overlap.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant