Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gradle wrapper and copy file path to the proper directory #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use gradle wrapper and copy file path to the proper directory #2

wants to merge 1 commit into from

Conversation

lfalkner
Copy link

No description provided.

Copy link
Contributor

@bhatti bhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Liz, I would be happy to add any changes that can help in general but am trying to understand reason for these changes. Please reply back with why those changes were necessary and what specific problems were they causing?

- run:
command: cd auto-circleci-plugin-1.2.0 && gradle run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>>
command: cp << parameters.auto_file >> auto-circleci-plugin-1.2.1/<< parameters.auto_file >>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you need to copy auto_file as you should be able to use full path such as auto_file: /tmp/myworkspace/test.apk?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bhatti Since the job is changing directories to auto-circleci-plugin-x.x.x, the file is not available at that path, even if I specify the path as stated above.

command: cd auto-circleci-plugin-1.2.0 && gradle run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>>
command: cp << parameters.auto_file >> auto-circleci-plugin-1.2.1/<< parameters.auto_file >>
- run:
command: cd auto-circleci-plugin-1.2.1 && ./gradlew run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue replacing gradle with ./gradlew but did you see any issues using gradle as it should be in the path of orb image.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that it was not in the path of the orb image

@lfalkner
Copy link
Author

Hi @bhatti I found that gradle was not available on the image in our jobs. In addition, the file was not available from the context where the job is running. These changes are meant to address both of those issues.
Thanks!

@bhatti
Copy link
Contributor

bhatti commented Jun 19, 2020

Hi @lfalkner , these changes didn't work for our circle-ci projects and I asked Brian Lawrence who is communicating with Corey Emerson to provide your circle-ci configs. I can work with your configs and we can update these configs so that they are both backward compatible and works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants