feat(react): upsert firstName, lastName, and email on session init#8142
Merged
djabarovgeorge merged 25 commits intoApr 28, 2025
Merged
Conversation
… subscriber session requests
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
scopsy
approved these changes
Apr 16, 2025
Contributor
scopsy
left a comment
scopsy
left a comment
There was a problem hiding this comment.
Wanted to do this for a long time 👏 What are your thoughts on props vs doing a subscriber object prop? @LetItRock wdyt?
…ibutes-with-inbox
@novu/js
@novu/nextjs
novu
@novu/react
@novu/react-native
commit: |
SokratisVidros
suggested changes
Apr 22, 2025
…ject in session handling
…r session requests
…ding phone, avatar, and custom data
…t command building function
djabarovgeorge
commented
Apr 23, 2025
djabarovgeorge
commented
Apr 23, 2025
djabarovgeorge
commented
Apr 27, 2025
| } | ||
|
|
||
| return data; | ||
| return convertedObject; |
Contributor
Author
There was a problem hiding this comment.
it is needed in order to get the default in the class like we have here
allowUpdate?: boolean = true;
otherwise the value is undefined.
any objection to this change?
Contributor
djabarovgeorge
commented
Apr 27, 2025
djabarovgeorge
commented
Apr 27, 2025
scopsy
approved these changes
Apr 27, 2025
| } | ||
|
|
||
| return data; | ||
| return convertedObject; |
Contributor
…ibutes-with-inbox
…ibutes-with-inbox
SokratisVidros
approved these changes
Apr 28, 2025
| readonly applicationIdentifier: string; | ||
|
|
||
| @IsString() | ||
| @IsOptional() |
Contributor
There was a problem hiding this comment.
This is the Inbox set of endpoint without OpenAPI or Speakeasy SDK yet.
| preferencesFilter?: PreferencesFilter; | ||
| routerPush?: RouterPush; | ||
| }; | ||
| } & ( |
Contributor
There was a problem hiding this comment.
You can export this type from @novu/js and reuse them in react.
Contributor
Author
There was a problem hiding this comment.
i thought about keeping It's simple with fewer types
djabarovgeorge
deleted the
nv-5683-support-of-upserting-subscriber-attributes-with-inbox
branch
desiprisg
pushed a commit
that referenced
this pull request
Apr 30, 2025
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer