feat(dashboard): Step conditions autosave#8134
Merged
desiprisg merged 1 commit intoApr 22, 2025
Merged
Conversation
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
desiprisg
force-pushed
the
nv-5344-add-autosave-functionality-to-step-conditions
branch
from
3d42bc2 to
a0d365b
Compare
desiprisg
force-pushed
the
nv-5344-add-autosave-functionality-to-step-conditions
branch
from
a0d365b to
9377221
Compare
SokratisVidros
approved these changes
Apr 22, 2025
LetItRock
requested changes
Apr 22, 2025
Contributor
LetItRock
left a comment
LetItRock
left a comment
There was a problem hiding this comment.
hey, found a few things that we need to improve:
- When I pick the field value with keyboard the page gets refreshed.
Screen.Recording.2025-04-22.at.12.53.38.mov
- When the field value changes we don't save the form right away.
Screen.Recording.2025-04-22.at.12.53.54.mov
- When the group or rule is removed the form is not saved right away.
Screen.Recording.2025-04-22.at.12.56.01.mov
- When group or rule is duplicated the page get's refreshed.
Screen.Recording.2025-04-22.at.12.56.21.mov
Comment on lines
+73
to
+75
| onAddRule={() => { | ||
| saveForm(); | ||
| return true; |
Contributor
There was a problem hiding this comment.
please define one callback and reuse it between the props
Comment on lines
+12
to
+15
| return { | ||
| ...uiSchemaDefaultValues, | ||
| ...controlValues, | ||
| }; |
Contributor
There was a problem hiding this comment.
why we needed to update this?
Contributor
Author
There was a problem hiding this comment.
There's a bug where if you visit step conditions and make a change before touching the template, your app crashes when visiting the template afterwards.
desiprisg
force-pushed
the
nv-5344-add-autosave-functionality-to-step-conditions
branch
from
9377221 to
e843f49
Compare
desiprisg
force-pushed
the
nv-5344-add-autosave-functionality-to-step-conditions
branch
from
e843f49 to
d08d68a
Compare
desiprisg
force-pushed
the
nv-5344-add-autosave-functionality-to-step-conditions
branch
from
d08d68a to
34e5fcd
Compare
LetItRock
approved these changes
Apr 22, 2025
Contributor
LetItRock
left a comment
LetItRock
left a comment
There was a problem hiding this comment.
nice, all works well! 🙌
desiprisg
deleted the
nv-5344-add-autosave-functionality-to-step-conditions
branch
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?