fix(dashboard): use more idiomatic react-querybuilder code#8059
Merged
Conversation
✅ Deploy preview added
To edit notification comments on pull requests, go to your Netlify project configuration. |
scopsy
approved these changes
Jun 8, 2025
Contributor
scopsy
left a comment
scopsy
left a comment
There was a problem hiding this comment.
Thank you @jakeboone02 appreciate it a lot!
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
Co-authored-by: Dima Grossman <dima@grossman.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The
prepareRuleGroupfunction is not necessary to addids to query objects generated fromparseJsonLogicsince v8.3.0 ofreact-querybuilder. This PR removes unnecessaryprepareRuleGroupcalls, updates the RQB dependency to v8.4.1, and moves an inline function prop to a stable reference to help with memoization.I don't know how this project manages dependency updates, so maybe you can't merge this directly but if nothing else it can provide a couple of usage tips.
Screenshots
N/A
Expand for optional sections
Related enterprise PR
Special notes for your reviewer
I'm the maintainer of
react-querybuilderand I just noticed this project. It's cool to see RQB being used so effectively! If you folks have any questions or feedback for me, please reach out!EDIT: One more thing—the "here" link on this line is dead (gets a 404):
novu/CONTRIBUTING.md
Line 59 in da9336d