fix(shared): remove uneeded AWS s3 env validators#8039
Merged
merrcury merged 1 commit intoJun 2, 2025
Conversation
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
Graphmaxer
changed the title
Contributor
|
@merrcury I don't see a reason of any downside of this. could you help with a review? |
Member
|
@merrcury ping |
merrcury
approved these changes
Jun 2, 2025
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
#8038
The variables
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYare not used directly by Novu but by the AWS S3 SDK.Other variables can be provided to ensure authentification like
AWS_ROLE_ARNandAWS_WEB_IDENTITY_TOKEN_FILE.Remove those validators allow to use other authentication methods like IRSA for AWS inside an EKS cluster.