fix(api-service): move workflow dto from shared to api#8009
fix(api-service): move workflow dto from shared to api#8009SokratisVidros merged 3 commits intonextfrom
Conversation
commit: |
227fbd3 to
19f82c4
Compare
4ce2174 to
3080a38
Compare
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
3080a38 to
1b85ee4
Compare
1b85ee4 to
345883d
Compare
b282bd7 to
427cbff
Compare
427cbff to
fe45720
Compare
SokratisVidros
left a comment
There was a problem hiding this comment.
This is an initial high level review. We are in the right direction and I am noting down the next actions in order to wrap this effort up:
- We need to do another pass around the Preference and Workflow V2 DTOs. There still a lot of duplication between these DTOs for request and responses.
- We need to solve the dual export issue for the internal SDK generated by speakeasy.
apps/api/src/app/bridge/usecases/preview-step/preview-step.usecase.ts
Outdated
Show resolved
Hide resolved
...nvironments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts
Show resolved
Hide resolved
| return { error: handleValidationErrorDto(e) }; | ||
| } | ||
| } | ||
| export class CustomHeaderHTTPClient extends HTTPClient { |
There was a problem hiding this comment.
Do we really need to extend the Speakeasy client at this point? Doesn't it allow us to override its headers on the spot?
There was a problem hiding this comment.
it allows us to do it only at the calls signature, I want to have it injected in all calls done with the instance, hence the requirement for this change.
| @@ -0,0 +1,22 @@ | |||
| import { ApiProperty } from '@nestjs/swagger'; | |||
|
|
|||
| export class SubscriberPreferenceTemplateResponseDto { | |||
There was a problem hiding this comment.
Template is the internal modelling of workflows. Some preference DTOs use the term workflow, others the term template. We should stick to workflow.
There was a problem hiding this comment.
I really don't want to make any additional changes besides whats a must in this huge PR, the purpose here is to document the existing state, lets move this to a seperate task
Resolve Workflow DTO Issues
What changed? Why was the change needed?
DTO Migration and Enhancements
unknownhad to be added in the framework to minimize scope.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer