fix(api-service): v1 widget and subscriber template preferences return tags #7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
commented
Mar 21, 2025
Comment on lines
132
to
+133
| tags: workflow.tags, | ||
| data: workflow.data, |
There was a problem hiding this comment.
the tags and data fields should be returned from the workflow preferences in v1, as the NC preferencesFilter could be used to filter the preferences by this information
Comment on lines
+496
to
+497
| tags: result.workflow.tags, | ||
| data: result.workflow.data, |
There was a problem hiding this comment.
return these fields on the PATCH endpoint in v1
4 tasks
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX,
tatarco,
djabarovgeorge and
desiprisg
SokratisVidros
approved these changes
Mar 21, 2025
BiswaViraj
approved these changes
Mar 21, 2025
SokratisVidros
deleted the
nv-4996-v1-widgets-subscribers-preferences-tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
API service changes: the v1 widgets and subscribers' GET/PATCH preferences endpoints should return the
tags, dataproperties from the workflow.Screenshots