chore(api-service): exclude demo workflows from limit validation #7952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
SokratisVidros
approved these changes
Mar 19, 2025
| @@ -12,6 +12,14 @@ import { NotificationStep } from '../usecases'; | |||
| import { FeatureFlagsService } from './feature-flags'; | |||
|
|
|||
| export const DAY_IN_MS = 24 * 60 * 60 * 1000; | |||
| const DEMO_WORKFLOWS_IDENTIFIER = [ | |||
There was a problem hiding this comment.
We need a more robust mechanism to identify demo workflows. What if as a user I delete the demo workflows and then create new ones with the same workflowId?
There was a problem hiding this comment.
that is a valid point i thought about creating a special tag for those templates, but at the moment it will not fix the problem as we still will need to migrate the old workflows.
at the current version we do not have this problem, even if a workflow was created from the template store it should be counted in the validation.
djabarovgeorge
deleted the
nv-5500-exclude-novu-created-demo-workflows-from-workflow-count-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer