fix(nextjs): Fix router compat when use client is used #7951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
LetItRock
approved these changes
Mar 18, 2025
SokratisVidros
force-pushed
the
fix_app_router_use_client
branch
from
5a7cd5d to
4806171
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Problem: An error seems to be thrown when using app directory and use client in the file that contains the Inbox.
I'm guessing this happens because use client causes our pages implementation to be used.
This means that it needs to be adaptive. We cannot execute useRouter from next/navigation in pages router and we cannot execute useRouter from next/router in app router.
We can have a InboxCommonProvider that will useRouter from next/compat/router. If that succeeds (it will be the next/router), it means that we are ok. If it fails, it means that the pages router could not be used and we should useRouter from next/navigation instead.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer