feat(dashboard,api-service): add self-hosted-auth #7755
Conversation
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →
|
… and streamline logMeIn method in AuthController, fix clerk mock
…y in SystemOrganizationService
…ed clerk mock file
…ls and remove redundant definition
…an up unused UserButton definition
…proved accessibility and consistency
… self-hosted redirection
…rade options and updated icons
…c URL for migration guide
| FROM alpine:latest | ||
| RUN apk add --no-cache busybox | ||
| WORKDIR /www | ||
| COPY --from=builder /usr/src/app/apps/dashboard/build /www | ||
| EXPOSE 80 | ||
| CMD ["busybox", "httpd", "-f", "-p", "80"] |
There was a problem hiding this comment.
@merrcury @djabarovgeorge remind, me how is the user going to modify the dashboard .env variables when starting this docker? For example changing the API_ROOT to his own domain after deploying, etc..
| <div> | ||
| <div className="flex flex-col items-center gap-1"> | ||
| <p className="text-text-soft text-label-xs mb-3 text-center"> | ||
| Unlock more environments and enhance your productivity |
There was a problem hiding this comment.
| Unlock more environments and enhance your productivity | |
| To create additional custom environments, upgrade your plan. |
apps/dashboard/src/components/environments/environments-free-state.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/main.tsx
Outdated
| @@ -106,7 +108,7 @@ const router = createBrowserRouter([ | |||
| children: [ | |||
| { | |||
| path: ROUTES.WELCOME, | |||
| element: <WelcomePage />, | |||
| element: IS_SELF_HOSTED ? <Navigate to={ROUTES.ROOT} replace /> : <WelcomePage />, | |||
There was a problem hiding this comment.
Is there a reason of why not keeping it? I think it might be helpful for onboarding, even on OSS. Wdyt?
There was a problem hiding this comment.
I think we need to revisit and restructure this page, some elements only partially make sense in the current context. For example, having both “Create Account” and “Invite Member” feels a bit out of place.
I’m not against having them, but we haven’t had a proper discussion around this yet.
A cleaner approach could be to focus on more actionable, relevant items like: "Create Workflow" "Add Inbox to Your App"
Let me know what you think. Open to feedback or other suggestions on how to streamline this page.
There was a problem hiding this comment.
i brought it back without the non-relevant steps, and the get started on the footer is back as well.
…and remove unused method
…pository and improve dependency injection
What changed? Why was the change needed?
docs update
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer