Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): create sidebar and switch components in novui #6390

Conversation

davidsoderberg
Copy link
Contributor

@davidsoderberg davidsoderberg commented Aug 26, 2024

Screenshot 2024-08-26 at 14 37 38

Copy link

linear bot commented Aug 26, 2024

@davidsoderberg davidsoderberg changed the title Nv 4227 create sidebar and switch components in novui Nv 4227(web): create sidebar and switch components in novui Aug 26, 2024
@davidsoderberg davidsoderberg changed the title Nv 4227(web): create sidebar and switch components in novui feat(web): create sidebar and switch components in novui Aug 26, 2024
Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions ❤️
Please also don't forget to add those to storybook 💃

libs/novui/src/components/sidebar/Sidebar.tsx Outdated Show resolved Hide resolved
libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
libs/novui/src/tokens/semanticColors.tokens.ts Outdated Show resolved Hide resolved
Comment on lines 18 to 40
export const TOGGLE_RECIPE = defineSlotRecipe({
className: 'toggle',
jsx: ['Toggle'],
slots: SLOTS,
base: {
track: {
borderRadius: 'pill',
backgroundColor: 'toggle.background',
border: 'none',
height: 150,
width: 250,
'input:checked + &': {
backgroundColor: 'toggle.checked',
},
},
thumb: {
backgroundColor: 'toggle.thumb',
border: 'none',
height: 125,
width: 125,
},
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support the gradient color as well? (for dashboard)

libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add Storybook stories -- it's the easiest way to develop in novui too!

libs/novui/src/components/toggle/Toggle.tsx Outdated Show resolved Hide resolved
libs/novui/src/recipes/sidebar.recipe.ts Outdated Show resolved Hide resolved
libs/novui/src/recipes/toggle.recipe.ts Show resolved Hide resolved
libs/novui/src/tokens/semanticColors.tokens.ts Outdated Show resolved Hide resolved
@SokratisVidros
Copy link
Contributor

@davidsoderberg Is this PR relevant anymore or should we close it?

@davidsoderberg
Copy link
Contributor Author

@davidsoderberg Is this PR relevant anymore or should we close it?

I am not sure, @antonjoel82 knows this as he took it over.

@antonjoel82
Copy link
Contributor

Since it sounds like we will just be using Mantine directly in the next iteration, there's no point in refining this at the moment, so closing it

@antonjoel82 antonjoel82 closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants