-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): create sidebar and switch components in novui #6390
feat(web): create sidebar and switch components in novui #6390
Conversation
davidsoderberg
commented
Aug 26, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions ❤️
Please also don't forget to add those to storybook 💃
export const TOGGLE_RECIPE = defineSlotRecipe({ | ||
className: 'toggle', | ||
jsx: ['Toggle'], | ||
slots: SLOTS, | ||
base: { | ||
track: { | ||
borderRadius: 'pill', | ||
backgroundColor: 'toggle.background', | ||
border: 'none', | ||
height: 150, | ||
width: 250, | ||
'input:checked + &': { | ||
backgroundColor: 'toggle.checked', | ||
}, | ||
}, | ||
thumb: { | ||
backgroundColor: 'toggle.thumb', | ||
border: 'none', | ||
height: 125, | ||
width: 125, | ||
}, | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it support the gradient color as well? (for dashboard)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to add Storybook stories -- it's the easiest way to develop in novui too!
@davidsoderberg Is this PR relevant anymore or should we close it? |
I am not sure, @antonjoel82 knows this as he took it over. |
Since it sounds like we will just be using Mantine directly in the next iteration, there's no point in refining this at the moment, so closing it |