Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Auto apply generic appearance keys via style() #6041

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Jul 11, 2024

What changed? Why was the change needed?

  • Appearance keys are now stored in an array to enable runtime checks
  • Appearance keys are formatted to allow instant knowledge about them being a primitive, or an extension of a primitive for a more specific usecase. Specifically, extension__primitive extends primitive.
  • style() automatically applies primitives based on this format. Use the more specific appearance key when creating a new element.
  • style() no longer receives an array of keys as an argument, in order to force the syntax to be the defining factor.

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link
Member

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@desiprisg desiprisg merged commit 5cb46a1 into next Jul 11, 2024
10 checks passed
@desiprisg desiprisg deleted the js_auto_appearance_keys branch July 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants