Skip to content

fix: remove get started onboarding experiment modal #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jainpawan21 merged 1 commit into from
May 1, 2024
Merged

fix: remove get started onboarding experiment modal #5475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/web/src/constants/experimentsConstants.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions apps/web/src/pages/auth/components/QuestionnaireForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,13 @@ import { ROUTES } from '../../../constants/routes.enum';
import { DynamicCheckBox } from './dynamic-checkbox/DynamicCheckBox';
import styled from '@emotion/styled/macro';
import { useDomainParser } from './useDomainHook';
import { OnboardingExperimentV2ModalKey } from '../../../constants/experimentsConstants';

export function QuestionnaireForm() {
const [loading, setLoading] = useState<boolean>();
const {
handleSubmit,
formState: { errors },
control,
setError,
} = useForm<IOrganizationCreateForm>({});
const navigate = useNavigate();
const { setToken, token } = useAuthContext();
Expand Down Expand Up @@ -69,7 +67,6 @@ export function QuestionnaireForm() {
const createDto: ICreateOrganizationDto = { ...rest, name: organizationName };
const organization = await createOrganizationMutation(createDto);
const organizationResponseToken = await api.post(`/v1/auth/organizations/${organization._id}/switch`, {});
localStorage.setItem(OnboardingExperimentV2ModalKey, 'true');
setToken(organizationResponseToken);
}

Expand Down
132 changes: 0 additions & 132 deletions apps/web/src/pages/quick-start/components/OnboardingExperimentModal.tsx
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions apps/web/src/pages/quick-start/steps/GetStarted.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import { ChannelsConfiguration } from '../components/ChannelsConfiguration';
import { GetStartedLayout } from '../components/layout/GetStartedLayout';
import { NavButton } from '../components/NavButton';
import { getStartedSteps, OnBoardingAnalyticsEnum } from '../consts';
import { OnboardingExperimentModal } from '../components/OnboardingExperimentModal';
import { useAuthContext } from '@novu/shared-web';
import { OnboardingExperimentV2ModalKey } from '../../../constants/experimentsConstants';

const ChannelsConfigurationHolder = styled.div`
display: flex;
Expand All @@ -28,20 +25,17 @@ const ChannelsConfigurationHolder = styled.div`

export function GetStarted() {
const segment = useSegment();
const { currentOrganization } = useAuthContext();

const [clickedChannel, setClickedChannel] = useState<{
open: boolean;
channelType?: ChannelTypeEnum;
}>({ open: false });

const isOnboardingModalEnabled =
localStorage.getItem(OnboardingExperimentV2ModalKey) === 'true' && window.innerWidth > 768;

const onIntegrationModalClose = () => setClickedChannel({ open: false });

useEffect(() => {
segment.track(OnBoardingAnalyticsEnum.CONFIGURE_PROVIDER_VISIT);
}, [currentOrganization?._id, isOnboardingModalEnabled, segment]);
}, [segment]);

function handleOnClick() {
segment.track(OnBoardingAnalyticsEnum.CONFIGURE_PROVIDER_NAVIGATION_NEXT_PAGE_CLICK);
Expand All @@ -67,7 +61,6 @@ export function GetStarted() {
/>
<ChannelsConfiguration setClickedChannel={setClickedChannel} />
</ChannelsConfigurationHolder>
{isOnboardingModalEnabled && <OnboardingExperimentModal />}
</GetStartedLayout>
);
}
Expand Down