Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node Mailer Provider #24

Closed
ComBarnea opened this issue Sep 25, 2021 · 6 comments
Closed

Add Node Mailer Provider #24

ComBarnea opened this issue Sep 25, 2021 · 6 comments

Comments

@ComBarnea
Copy link
Collaborator

ComBarnea commented Sep 25, 2021

What?

New Node Mailer Email Provider

Why?

To have the ability to use Node Mailer, smtp as a provider.

How?

Add new provider based on this guide

Usage

Example for Node Mailer provider registration using smtp, need to be finalized.

await notifire.registerProvider(
  new NodeMailerProvider({
    from: "[email protected]",
    host: "smtp.test.email",
    port: 587,
    secure: false, // true for 465, false for other ports
    user: "userName", // generated ethereal user
    password: "password",
  })
);
@painotpi
Copy link
Contributor

painotpi commented Oct 5, 2021

Hey, can I pick this?

@scopsy
Copy link
Contributor

scopsy commented Oct 5, 2021

@painotpi Sure!

What you can do is copy the SendGrid provider and create a new folder for NodeMailer implementing the IEmailProvider.

Attaching a short explanation on our docs https://docs.notifire.co/docs/community/create-provider (needs to be improved but a good start).

@scopsy scopsy assigned scopsy and painotpi and unassigned scopsy Oct 5, 2021
@scopsy
Copy link
Contributor

scopsy commented Oct 5, 2021

@painotpi Just noticed that the doc link I gave you is not updated, instead of cloning the template, create a fork of this project notifire and create a folder in providers and add the new provider there.

Sorry for the confusion

@painotpi
Copy link
Contributor

painotpi commented Oct 6, 2021

@scopsy No worries, I had started by cloning the template, should I redo it by copying an existing provider folder instead?

@scopsy
Copy link
Contributor

scopsy commented Oct 6, 2021

@painotpi Yes, it's better to integrate it already to the monorepo. You can just copy the directory you cloned (without the .git file) and add it to the providers folder here.

@ComBarnea
Copy link
Collaborator Author

Closed by #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants