-
Notifications
You must be signed in to change notification settings - Fork 112
Update docs for the FCM guide #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for docs-novu failed. Why did it fail? →
|
WalkthroughRewrites the FCM integration doc into a step-based guide (Steps 1–4), adds tabbed Node.js and cURL examples, documents per-integration token storage via integrationIdentifier, expands runtime overrides (android, apns, webPush, fcmOptions), adds topic and web-push link examples, and renames a navigation label in meta.json. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant Firebase as Firebase Console/API
participant Novu as Novu (API/UI)
participant Device as Client Device
rect rgba(135,206,235,0.12)
Dev->>Firebase: Create project & service account, download JSON (Step 1)
Firebase-->>Dev: Service account JSON (contains required fields)
end
rect rgba(144,238,144,0.12)
Dev->>Novu: Upload credentials / set integration (Step 2) \n(uses integrationIdentifier for per-integration tokens)
Novu-->>Dev: Integration registered
end
rect rgba(255,228,181,0.12)
Device->>Novu: Register device token (include integrationIdentifier) (Step 3)
Novu-->>Device: Ack
end
rect rgba(221,160,221,0.12)
Dev->>Novu: Send notification (Step 4) with overrides (android/apns/webPush/fcmOptions) or topic
Novu->>Firebase: Deliver push (selects integration by integrationIdentifier)
Firebase->>Device: Push notification
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/docs/platform/integrations/push/(providers)/fcm.mdx (1)
337-344
: Use correct casing forfcmOptions
.The overrides API expects
fcmOptions
(camelCase). Withfcm_options
, the link override is ignored, so web push redirects break.Apply this diff:
- "webPush": { - "fcm_options": { + "webPush": { + "fcmOptions": {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
public/images/channels-and-providers/push/confirmation-menu.png
is excluded by!**/*.png
public/images/channels-and-providers/push/firebase-project-settings.png
is excluded by!**/*.png
public/images/channels-and-providers/push/firebase-service-accounts.png
is excluded by!**/*.png
public/images/channels-and-providers/push/integrationidentifier.png
is excluded by!**/*.png
public/images/channels-and-providers/push/select-firebase-project.png
is excluded by!**/*.png
📒 Files selected for processing (2)
content/docs/platform/integrations/push/(providers)/fcm.mdx
(3 hunks)content/docs/platform/meta.json
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
content/docs/platform/integrations/push/(providers)/fcm.mdx
[grammar] ~49-~49: There might be a mistake here.
Context: ...tion Store** page on the Novu dashboard. 3. Click Connect provider. 4. Under the...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
- GitHub Check: Build and Lint
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
First, you need to get your project's service account credentials from the Firebase Console. | ||
|
||
1. Log in to the [Firebase console](https://console.firebase.google.com/). | ||
2. Created a new Firebase project or select an existing project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tense in instruction.
Please change “Created a new Firebase project…” to “Create a new Firebase project…” for correct imperative wording.
🤖 Prompt for AI Agents
In content/docs/platform/integrations/push/(providers)/fcm.mdx around line 18,
the instruction uses past tense ("Created a new Firebase project..."); change it
to the imperative present tense by replacing "Created" with "Create" so the step
reads "Create a new Firebase project or select an existing project."
Summary by CodeRabbit