-
Notifications
You must be signed in to change notification settings - Fork 111
docs: add keyless mode section to Inbox documentation #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Introduced a new section explaining the Keyless mode for the `<Inbox />` component, allowing users to test and explore features without prior setup. - Included a code example for integrating the Inbox component in a React application. - Added a callout encouraging users to sign up for a full experience with Novu Cloud.
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughThe documentation for the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
content/docs/platform/inbox/react/components/inbox.mdx (1)
32-34: Duplicate Callout ContentThis callout content matches the suggestion made by jainpawan21 in a previous review.
🧹 Nitpick comments (4)
content/docs/platform/inbox/react/components/inbox.mdx (4)
11-14: Consistent Capitalization for 'Keyless Mode'The header uses “Keyless Mode” (capitalized “Mode”) but the paragraph text uses “Keyless mode” (lowercase “mode”). For clarity, pick one style and apply it consistently in both the heading and body.
15-30: Optimize React Import in the ExampleSince React 17+ supports JSX without an explicit
import React from 'react';, you may remove that import to streamline the snippet. If you keep it for backward compatibility, consider noting that it’s optional in newer React versions.
159-159: Highlight Timezone NoteConsider wrapping this standalone sentence in a
<Callout type="info">so it stands out like other informational nuggets (e.g., snooze constraints) and doesn’t get overlooked in the prose.
205-205: Refine Custom Tabs GuidanceTo improve readability, rephrase to active voice. For example:
“To add a Snoozed or Reminders tab when using custom tabs in<Inbox />, includesnoozed: truein your tabs configuration.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/docs/platform/inbox/react/components/inbox.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Build and Lint
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
<Inbox />component, allowing users to test and explore features without prior setup.Summary by CodeRabbit