This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
#43 version name is unspecified #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 12, 2015 17:07
avoids conflicts with gradle defaults
android deprecating version in favour of publishVersion
|
fixes #43 |
| } | ||
|
|
||
| def getPublishVersion() { | ||
| getString(project, 'publishVersion', extension.publishVersion == null ? extension.version : extension.publishVersion) |
There was a problem hiding this comment.
getString(project, 'publishVersion', extension.publishVersion ?: extension.version)
http://docs.groovy-lang.org/latest/html/documentation/index.html#_elvis_operator
The "Elvis operator" is a shortening of the ternary operator. Basically means if not null null return myself
with the Elvis operator, the value which is tested is used if it is not false or null
There was a problem hiding this comment.
that is such a good idea 👍
|
nice action 👍 |
|
@blundell comments addressed |
|
👍 |
blundell
added a commit
that referenced
this pull request
Apr 12, 2015
#43 version name is unspecified
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the "version" param is favour of "publishVersion" to avoid conflicts with gradle's
project.versionwhen usingpropertiesFixes unspecified version name by applying the same property finding logic to both the
maven publicationand thebintray configuration