This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Upgrade Gradle to 5.1.1 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when not needed
mr-archano
commented
Apr 26, 2019
| @@ -103,11 +108,15 @@ class ReleasePluginTest { | |||
|
|
|||
| @Test | |||
| void shouldGenerateJavadocs() { | |||
| skipTestWhen(configuration.android && configuration.gradleVersion >= GRADLE_4_10_1) | |||
There was a problem hiding this comment.
Unfortunately I realised that the generation of the javadoc artifact is broken for recent versions of the Android Gradle Plugin, so I decided to skip these tests while we find a robust solution for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base plugin was still using 4.3, but since we have introduced the compat layer (#249) this is not a strict requirement anymore.
Incidentally I have added a way to run a subset of the compatibility tests in
ReleasePluginTest. By default now we will run all the tests using Gradle 5.1+ (this should speed up the PRB considerably).If you want to run the whole suite of compatibility tests you can specify the minimum version of Gradle to consider for those at command line, eg: