Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Add check if there is already a maven publication #267

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Add check if there is already a maven publication #267

merged 1 commit into from
Mar 9, 2019

Conversation

rekire
Copy link
Contributor

@rekire rekire commented Mar 6, 2019

This change is intended to fully customize the pom file as you like, by defining your own publication. This should resolve #266

@hal9002
Copy link

hal9002 commented Mar 6, 2019

Can one of the admins review this PR?

@mr-archano
Copy link
Contributor

@hal90002 retest this please

@mr-archano mr-archano closed this Mar 7, 2019
@mr-archano mr-archano changed the base branch from master to develop March 7, 2019 17:00
@mr-archano
Copy link
Contributor

@rekire thanks for the collaboration. I changed the base branch as we use develop to accept new features and master is used only to do releases.

@mr-archano mr-archano reopened this Mar 7, 2019
@mr-archano
Copy link
Contributor

@rekire something is weird with this merge. Could you please rebase your branch on latest develop and force push?

@rekire
Add check if there is already a maven publication
565d54b 
This change is intended to fully customize the pom file as you like.
@rekire
Copy link
Contributor Author

rekire commented Mar 8, 2019

I tried that, I hope it worked. I just saw that you did a force push two hours ago. I hope I didn't break your work.

@mr-archano
Copy link
Contributor

It seems ok, thanks @rekire.

I would like to extend this functionality in order to improve configurability. Also we would need to keep things in sync with Android libraries too. But that can wait.
I was thinking that we could just merge this so you will be able to use a snapshot of the plugin (see instructions) and solve your issue. what do you think?

@mr-archano
Copy link
Contributor

@hal90002 retest this please

@rekire
Copy link
Contributor Author

rekire commented Mar 8, 2019

That sounds fine for me. Just for my curiosity which tasks are open before the next release?

@mr-archano
Copy link
Contributor

@rekire there's no milestone defined yet. I was just thinking of improving upon your idea so we could release a more robust yet flexible solution.

mr-archano
mr-archano approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@mr-archano mr-archano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I thought I merged this already 😅

@mr-archano mr-archano merged commit 2b226c2 into novoda:develop Mar 9, 2019
@mr-archano mr-archano mentioned this pull request Mar 9, 2019
Closed
@rekire rekire deleted the feature/check_if_maven_publication_exists branch March 9, 2019 20:16
@rekire
Copy link
Contributor Author

rekire commented Mar 9, 2019

Everything is fine. Thanks for merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mr-archano mr-archano mr-archano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekire @hal9002 @mr-archano