22/Use version property if available #23
Conversation
|
fixes #22 |
|
To test, I released locally and removed the version property from build.gradle and run with -Pversion=1.0.0. The result can be seen below:
|
|
should we add to the readme a link to this PR and say version can also be supplied on the command line see here |
| @@ -42,4 +43,8 @@ class ReleasePlugin implements Plugin<Project> { | |||
| } | |||
| } | |||
|
|
|||
| private String getString(Project project, String propertyName, String defaultValue) { | |||
There was a problem hiding this comment.
private def getProperty ?
|
Once released, the wiki needs to be updated as well |
|
LGETM 👍 |
| @@ -36,8 +36,8 @@ publish { | |||
| userOrg = 'novoda' | |||
| groupId = 'com.novoda' | |||
| artifactId = 'bintray-release' | |||
| version = '0.2.7' | |||
| description = 'Oh hi, this is a nice description for a project right?' | |||
| version = '0.2.8' // since 0.2.8, version can also be supplied on the command line. [See here](https://github.com/novoda/bintray-release/pull/23) | |||
There was a problem hiding this comment.
not sure if this comment should be here
There was a problem hiding this comment.
yeah same - looks more like something in the wiki/release notes when you create a tag
|
yeah either add it to the wiki or the README https://github.com/novoda/bintray-release/wiki |
22/Use version property if available
|
do we want to do a release with this change? |
|
release often,.. [image: --] 2015-03-26 18:29 GMT+01:00 Adam Brown [email protected]:
|
|
This change broke releasing without specifying the version via the properties |
|
😱 what shouldn't we have done? |
|
as @ouchadam mentioned to me the issue might be that |
|
Yes, hasProperty returns true, but getProperty returns unspecified. [image: --] 2015-04-02 12:46 GMT+02:00 Xavi Rigau [email protected]:
|
This PR adds the possibility to make publish.version optional and define the version of the release as a project property, e.g. in a gradle file
or as a command line parameter