websockify does not react to SIGTERM #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child processes are not terminated when parent process of websockify is killed. In this fix made provision to terminate all child processes when parent process is killed. Fixes novnc#138
|
I've made a couple of tweaks (I removed an unnecessary PID check, since active_children is supposed to only return children of the current process, and make some tweaks to the commit message). In general LGTM 👍 |
DirectXMan12
added a commit
that referenced
this pull request
Feb 18, 2016
Make websockify respond to SIGTERM
|
closed with 4e6938e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child processes are not terminated when parent process of websockify
is killed.
In this fix made provision to terminate all child processes when
parent process is killed.
Fixes #138