Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce strict mode #174

Merged
merged 1 commit into from
May 13, 2015
Merged

Introduce strict mode #174

merged 1 commit into from
May 13, 2015

Conversation

DirectXMan12
Copy link
Member

This commit introduces strict mode, which is on by default. Currently
strict mode only enforces client-to-server frame masking. However,
in the future, it might enforce other parts of the RFC as well.

Closes #164

@DirectXMan12 DirectXMan12 force-pushed the feature/strict-mode branch from 36f0266 to 1440e50 Compare May 12, 2015 20:44
@DirectXMan12 DirectXMan12 added this to the v0.7.0 milestone May 12, 2015
@DirectXMan12 DirectXMan12 added bug Something isn't working feature New feature or request labels May 12, 2015
@DirectXMan12
Copy link
Member Author

@kanaka , @samhed : look good for what we talked about in #164 ?

@DirectXMan12
Copy link
Member Author

(I'll add tests once the test refactor in #172 lands)

@kanaka
Copy link
Member

kanaka commented May 12, 2015

Looks good to me.

@samhed
Copy link
Member

samhed commented May 12, 2015

Great!

@DirectXMan12 DirectXMan12 force-pushed the feature/strict-mode branch from 1440e50 to e66d2fa Compare May 13, 2015 18:34
This commit introduces strict mode, which is on by default.  Currently
strict mode only enforces client-to-server frame masking.  However,
in the future, it might enforce other parts of the RFC as well.

Closes #164
@DirectXMan12 DirectXMan12 force-pushed the feature/strict-mode branch from e66d2fa to 3769f71 Compare May 13, 2015 19:11
DirectXMan12 added a commit that referenced this pull request May 13, 2015
@DirectXMan12 DirectXMan12 merged commit 6dd1974 into master May 13, 2015
@DirectXMan12 DirectXMan12 deleted the feature/strict-mode branch May 13, 2015 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websockify accepts unmasked frames
3 participants