Implement Ping and Pong heartbeat messages #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the websockify server to respond to heart beat ping messages sent by clients
|
Ok, thanks! Unnecessary pack statement removed. |
|
Besides the nit, LGTM 👍 |
With this option we will ping the client with a heartbeat. Helpful for connection through firewalls that may disable inactive connections.
|
All right. I have updated to match your recommendation. Thanks for the review. |
|
Anything further I need to do to allow this to be able to get accepted? Thanks! |
DirectXMan12
added a commit
that referenced
this pull request
Apr 21, 2015
Implement Ping and Pong heartbeat messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations to handle ping and pong heartbeat messages to help with connections through firewalls or proxies and such where regular keep alive traffic would be required.