BUGFIX: Websocket frame corruption on big-endian #150 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, but those trailing whitespaces annoy me! 😄 |
|
@rafaelfolco : can you fix the whitespace, please? Otherwise, this looks great. |
|
Looks okay to me apart from whitespace. This is in the main data path and I'm always concerned about adding even small amounts of latency there, but one extra check for the big endian case shouldn't have any effect. |
|
commit d56a2e5 addresses the whitespace. Please let me know if any other concerns. Thanks. |
|
Could you just squash the two commits together? Just so we can keep our history cleaner. You can use git push --force after making the changes so you don't have to do a new PR. |
This patch fixes noVNC endianess problem on handshake. It affects noVNC sessions on Big Endian platforms. Fixes novnc#150
rafaelfolco
force-pushed
the
bug/150-websocket-bigendian
branch
from
d56a2e5 to
af10f45
Compare
DirectXMan12
added a commit
that referenced
this pull request
Apr 7, 2015
BUGFIX: Websocket frame corruption on big-endian #150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes noVNC endianess problem on handshake.
It affects noVNC sessions on Big Endian platforms.
Fixes #150