Make items objects instead of arrays for tuples #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for biocad#31 If the tuples has homogeneous types, the generated schema is strict. On the other hand if there are heterogeneous types, the schema is not very strict because the order in which the types must come is not specified. Also, I had to use anyOf instead of oneOf because for example the int in (Int, Float) matches both Integer and Number. Finally, special care had to be taken to handle nullables.
teto
reviewed
Feb 3, 2023
| prop "(Set Bool)" $ shouldValidate (Proxy :: Proxy (Set Bool)) | ||
| prop "(NonEmpty Bool)" $ shouldValidate (Proxy :: Proxy (NonEmpty Bool)) | ||
| prop "(HashSet Bool)" $ shouldValidate (Proxy :: Proxy (HashSet Bool)) | ||
| prop "(Either Int String)" $ shouldValidate (Proxy :: Proxy (Either Int String)) | ||
| prop "(Int, String)" $ shouldValidate (Proxy :: Proxy (Int, String)) | ||
| -- prop "(Int, String)" $ shouldValidate (Proxy :: Proxy (Int, String)) |
There was a problem hiding this comment.
are these commented tests expected ? didn't want to update the template schema ?
There was a problem hiding this comment.
Those tests are checking that for any JSON value generated matching the schema generated by the ToSchema instance of (Int, String), we are able to parse it to (Int, String).
An example might make it clearer, we try to check whether we can parse [1, "hello"] to a (Int, String) which we can.
However, since the only constraints we have is having two elements of type Int or String, we also try [1, 1], ["hello", "bye"] and ["hello", 1] which we cannot parse to (Int, String).
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for biocad#31
If the tuples has homogeneous types, the generated schema is strict. On the other hand if there are heterogeneous types, the schema is not very strict because the order in which the types must come is not specified.
Also, I had to use anyOf instead of oneOf because for example the int in (Int, Float) matches both Integer and Number.
Finally, special care had to be taken to handle nullables.