-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add editor width setting #91
Conversation
Good job! |
Thanks! Sorry for the late answer. I immediately wanted to get started on my ideas, but life got in the way. Initially I was thinking about adding it in the SidebarMenu, but adding a dropdown there would not look nice. An alternative idea is to only support 2 sizes: small (current) and big, with a simple list item called "Toggle editor width", then I would remove the other 2 options from the settings page as well. EDIT: just another thought I had: What if the user wants to remove the page specific config? Do we then also need to foresee a way to reset the page specific setting like a second menu item "Reset editor width", or a button in the settings that will reset everything at once? |
The settings of each note can be put in meta We only need to support two widths in the top menu, the default and the larger width. https://github.com/QingWei-Li/notea/blob/main/components/note-nav.tsx#L138 If necessary in the future, we can add more width options and reset the width option. |
@@ -105,7 +105,7 @@ export const EditContainer = () => { | |||
<NoteNav /> | |||
<DeleteAlert /> | |||
<section className="h-full"> | |||
<MainEditor /> | |||
<MainEditor note={note} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like typescript didn't catch this because of the async import. Didn't notice any side effects when adding this.
Hi there, as mentioned on my discussions page, I've added a "editor width" setting. Feel free to review/merge if you feel this is something that fits in your idea of the editor 😄
Currently there are only 2 sizes with the ability to toggle between them on a page by page basis, with a default setting.
Screenshots