Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add crl cache debug logs #473

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

Two-Hearts
Copy link
Contributor

This PR adds debug logs to crl cache since crl cache errors can be set to discard.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts reopened this Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.28%. Comparing base (1dc55d0) to head (2d464b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
verifier/crl/crl.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   80.25%   80.28%   +0.02%     
==========================================
  Files          34       34              
  Lines        3318     3328      +10     
==========================================
+ Hits         2663     2672       +9     
- Misses        509      510       +1     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit c6c8cc7 into notaryproject:main Nov 3, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the log branch November 3, 2024 12:19
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this pull request Dec 9, 2024
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this pull request Dec 9, 2024
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this pull request Dec 9, 2024
@Two-Hearts Two-Hearts mentioned this pull request Dec 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants