Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove blob sign/verify for v1.3.0-rc.1 release #464

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Sep 26, 2024

This PR is for release-1.3 branch.

It removes the blob sign/verify from this version. The commit is cherry picked from what we had in v1.2.

Signed-off-by: Patrick Zheng <[email protected]>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.71%. Comparing base (84c2ec0) to head (b9e098b).
Report is 1 commits behind head on release-1.3.

Files with missing lines Patch % Lines
verifier/verifier.go 82.35% 2 Missing and 1 partial ⚠️
verifier/trustpolicy/oci.go 95.23% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.3     #464      +/-   ##
===============================================
+ Coverage        81.34%   81.71%   +0.37%     
===============================================
  Files               34       33       -1     
  Lines             2578     2374     -204     
===============================================
- Hits              2097     1940     -157     
+ Misses             335      302      -33     
+ Partials           146      132      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

Other maintainers may take a look at https://github.com/notaryproject/notation-go/compare/v1.2.1..b9e098b21ddbd1f0426a094458e9e7bf5a434d75 for faster review.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 3c49488 into notaryproject:release-1.3 Sep 27, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch September 27, 2024 00:25
@Two-Hearts Two-Hearts mentioned this pull request Sep 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants