-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove blob sign/verify for v1.3.0-rc.1 release #464
Conversation
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #464 +/- ##
===============================================
+ Coverage 81.34% 81.71% +0.37%
===============================================
Files 34 33 -1
Lines 2578 2374 -204
===============================================
- Hits 2097 1940 -157
+ Misses 335 302 -33
+ Partials 146 132 -14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Other maintainers may take a look at https://github.com/notaryproject/notation-go/compare/v1.2.1..b9e098b21ddbd1f0426a094458e9e7bf5a434d75 for faster review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is for
release-1.3
branch.It removes the blob sign/verify from this version. The commit is cherry picked from what we had in v1.2.