test: add trustpolicy fuzzer #461
Conversation
AdamKorcz
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 34 34
Lines 2578 2578
=======================================
Hits 2097 2097
Misses 335 335
Partials 146 146 ☔ View full report in Codecov by Sentry. |
|
@AdamKorcz You may need to merge latest changes. |
done |
|
@AdamKorcz You may need to merge the latest changes and sign-off the commit again. |
done |
Signed-off-by: Adam Korczynski <[email protected]>
|
Have signed the commit. |
| @@ -3,6 +3,7 @@ module github.com/notaryproject/notation-go | |||
| go 1.22.0 | |||
|
|
|||
| require ( | |||
| github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6 | |||
There was a problem hiding this comment.
This PR is bringing in a new 3rd party dependency to notation-go.
@shizhMSFT @priteshbandi would like to know your thoughts regarding this change.
There was a problem hiding this comment.
New dependency should not be added. If github.com/AdaLogics/go-fuzz-headers is really required for testing, we should create a nested model like https://github.com/notaryproject/notation/tree/main/test/e2e
| @@ -3,6 +3,7 @@ module github.com/notaryproject/notation-go | |||
| go 1.22.0 | |||
|
|
|||
| require ( | |||
| github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6 | |||
There was a problem hiding this comment.
New dependency should not be added. If github.com/AdaLogics/go-fuzz-headers is really required for testing, we should create a nested model like https://github.com/notaryproject/notation/tree/main/test/e2e
|
@AdamKorcz Would you mind updating the branch and addressing the comments by Shiwei. Let me know if you need any support on this. Thanks. |
|
This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days. |
Moves this fuzzer upstream from cncf-fuzzing. Adds a dependency to randomize structs.