Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fuzz test #459

Merged
merged 1 commit into from
Sep 29, 2024
Merged

test: add fuzz test #459

merged 1 commit into from
Sep 29, 2024

Conversation

AdamKorcz
Copy link
Contributor

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (84c2ec0) to head (da93344).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          34       34           
  Lines        2578     2578           
=======================================
  Hits         2097     2097           
  Misses        335      335           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yizha1
Copy link
Contributor

yizha1 commented Sep 26, 2024

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

done

@Two-Hearts
Copy link
Contributor

Hi @AdamKorcz, same to the notation-core-go PR, you will need to use the -S flag in your git command to sign the commit (needs to be capital S). The -s or --signoff flags only signoff the commit but not signing it.

Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Contributor Author

Have signed the commit.

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts changed the title add fuzz test test: add fuzz test Sep 27, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit a86f8da into notaryproject:main Sep 29, 2024
9 checks passed
Two-Hearts pushed a commit to Two-Hearts/notation-go that referenced this pull request Dec 9, 2024
@Two-Hearts Two-Hearts mentioned this pull request Dec 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants