Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crl support #458

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao [email protected]

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (694e3a0) to head (82ddf9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   80.98%   81.01%   +0.03%     
==========================================
  Files          33       33              
  Lines        2487     2492       +5     
==========================================
+ Hits         2014     2019       +5     
  Misses        331      331              
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and hold for dependency update

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

commit a69fd62
Author: Junjie Gao <[email protected]>
Date:   Wed Sep 18 01:36:05 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit c26dabb
Author: Junjie Gao <[email protected]>
Date:   Sat Sep 14 06:22:15 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit 00d464f
Author: Junjie Gao <[email protected]>
Date:   Sat Sep 14 06:17:25 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit b7bbef4
Author: Junjie Gao <[email protected]>
Date:   Sat Sep 14 00:40:10 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit c00b956
Author: Junjie Gao <[email protected]>
Date:   Tue Sep 10 08:18:39 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit 8437ba1
Author: Junjie Gao <[email protected]>
Date:   Tue Sep 10 08:16:39 2024 +0000

    feat: add CRL support

    Signed-off-by: Junjie Gao <[email protected]>

commit cdfdd68
Merge: 6e816b5 694e3a0
Author: Junjie Gao <[email protected]>
Date:   Tue Sep 10 06:25:59 2024 +0000

    Merge remote-tracking branch 'upstream/main' into feat/crl_no_cache

commit 6e816b5
Author: Junjie Gao <[email protected]>
Date:   Tue Aug 27 06:05:11 2024 +0000

    fix: update

    Signed-off-by: Junjie Gao <[email protected]>

commit 640b3bb
Author: Junjie Gao <[email protected]>
Date:   Tue Aug 20 07:20:27 2024 +0000

    feat: support CRL

    Signed-off-by: Junjie Gao <[email protected]>

Signed-off-by: Junjie Gao <[email protected]>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 7c20eba into notaryproject:main Sep 18, 2024
9 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Sep 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants