Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved org maintainers to emeritus #393

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Apr 1, 2024

Two-Hearts
Two-Hearts previously approved these changes Apr 1, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Apr 2, 2024
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Toddy Mladenov <[email protected]>
@toddysm toddysm dismissed stale reviews from priteshbandi and Two-Hearts via f51578f April 2, 2024 00:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (9ff1891) to head (a54779b).
Report is 12 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   73.43%   76.04%   +2.60%     
==========================================
  Files          24       30       +6     
  Lines        2507     2158     -349     
==========================================
- Hits         1841     1641     -200     
+ Misses        526      371     -155     
- Partials      140      146       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddysm toddysm merged commit 2d65f6e into notaryproject:main Apr 4, 2024
7 checks passed
JeyJeyGao pushed a commit that referenced this pull request May 29, 2024
This was referenced May 29, 2024
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants