-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The verbose log for checking trust policy lacks intuitiveness #430
Comments
yizha1
added
bug
Something isn't working
triage
Needs evaluation for feasibility, timeline, etc.
labels
Aug 2, 2024
Two-Hearts
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Oct 8, 2024
Merged
github-project-automation
bot
moved this from Todo
to Done
in Notary Project Planning Board
Oct 16, 2024
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 10, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 10, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is not working as expected?
When using the
notation verify
command with the flag-v
, the following logs will be shown:The logs indicated that trust policy is being checked to see whether signature verification will be skipped or not. The last log indicated that the check is over. However, the sentence
Trust policy is not configured to skip signature verification
is not well written, there is a double negative in the sentence, which is not easy to understand.What did you expect to happen?
Improve the sentence
Trust policy is not configured to skip signature verification
to make it more intutive.If trust policy is configured for signature verification, then the log can be
If trust policy is configured to skip signature verification, then the log can be
How can we reproduce it?
Use
notation verify
command with-v
flag.Describe your environment
Linux OS
What is the version of your notation-go Library?
v1.2.0-beta.1
The text was updated successfully, but these errors were encountered: