Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The verbose log for checking trust policy lacks intuitiveness #430

Closed
yizha1 opened this issue Aug 2, 2024 · 0 comments · Fixed by #469
Closed

The verbose log for checking trust policy lacks intuitiveness #430

yizha1 opened this issue Aug 2, 2024 · 0 comments · Fixed by #469
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yizha1
Copy link
Contributor

yizha1 commented Aug 2, 2024

What is not working as expected?

When using the notation verify command with the flag -v, the following logs will be shown:

INFO Checking whether signature verification should be skipped or not
INFO Trust policy configuration:
INFO Check over. Trust policy is not configured to skip signature verification

The logs indicated that trust policy is being checked to see whether signature verification will be skipped or not. The last log indicated that the check is over. However, the sentence Trust policy is not configured to skip signature verification is not well written, there is a double negative in the sentence, which is not easy to understand.

What did you expect to happen?

Improve the sentence Trust policy is not configured to skip signature verification to make it more intutive.

If trust policy is configured for signature verification, then the log can be

Trust policy is configured for signature verification at level strict.

If trust policy is configured to skip signature verification, then the log can be

Trust policy is configured to skip signature verification.

How can we reproduce it?

Use notation verify command with -v flag.

Describe your environment

Linux OS

What is the version of your notation-go Library?

v1.2.0-beta.1

@yizha1 yizha1 added bug Something isn't working triage Needs evaluation for feasibility, timeline, etc. labels Aug 2, 2024
@Two-Hearts Two-Hearts self-assigned this Aug 5, 2024
@Two-Hearts Two-Hearts added this to the 1.2.0 milestone Aug 5, 2024
@yizha1 yizha1 removed the triage Needs evaluation for feasibility, timeline, etc. label Aug 6, 2024
@yizha1 yizha1 modified the milestones: 1.2.0, 1.3.0 Sep 3, 2024
@Two-Hearts Two-Hearts added enhancement New feature or request and removed bug Something isn't working labels Oct 8, 2024
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this issue Dec 9, 2024
This PR updates logs.
Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this issue Dec 9, 2024
This PR updates logs.
Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this issue Dec 9, 2024
This PR updates logs.
Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this issue Dec 10, 2024
This PR updates logs.
Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts added a commit to Two-Hearts/notation-go that referenced this issue Dec 10, 2024
This PR updates logs.
Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004.

Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants