use tabwriter in favour of tablewriter #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
|
this is awesome! I'm still digging into the delegation prints for multiple keys/paths but here are some screenshots for the interested. Main difference is the underlining at the top of the table is slightly different (which is fine with me):
|
|
LGTM! Tested with multiple delegation keys and paths, looks good!
|
|
Awesome, LGTM! Thanks for all the screenshots @riyazdf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #805
The formatting isn't 100% identical but it's very close and it still looks good. I had to do some manual formatting for the role printing where tablewriter handled multi-line rows cleanly. Overall though I think this is a good tradeoff for the removal of the dependency.
No rush to merge this. Happy to leave it open for a while and see how people feel.