Carry v0.4.3 master bump #1072
Merged
Carry v0.4.3 master bump #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
reviewed
Jan 5, 2017
| -ldflags "-w ${CTIMEVAR} ${LDFLAGS}" \ | ||
| ./cmd/notary; | ||
| set +x; | ||
| done |
There was a problem hiding this comment.
Non-blocking nitpicky-ness - could we add a newline afterward?
riyazdf
force-pushed
the
v0.4.3-master-bump
branch
2 times, most recently
from
c549cd6 to
a30769d
Compare
|
@riyazdf can you rebase then assuming tests pass we're good to merge. |
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
… slash Also updates a test to fix the expected vs actual values. Signed-off-by: Riyaz Faizullabhoy <[email protected]>
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
riyazdf
force-pushed
the
v0.4.3-master-bump
branch
from
a30769d to
4cf0688
Compare
|
green after rebase! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carries patches from v0.4.3 back to master - the delegation key import panic fix and netgo flag for server flag panic.
There was some messiness because of repeat lint commits that already made it to master, so I removed those in this PR.