fixing default records size for changefeed #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
approved these changes
Nov 14, 2016
| if pageSize == 0 { | ||
| pageSize = notary.DefaultPageSize | ||
| } | ||
| } else { | ||
| pageSize = notary.DefaultPageSize |
There was a problem hiding this comment.
Non-blocking stylistic nit: rather than an if/else, we just set pageSize = notary.DefaultPageSize above the if statement. Happy to just get this in as is, though.
There was a problem hiding this comment.
Do we also have a test for this when testing the changefeed inputs?
There was a problem hiding this comment.
Will add test so don't merge yet :-)
Re. first comment, I can make that change too. Had this style drilled into me a long time ago so it's my go to. Happy to do it other ways.
There was a problem hiding this comment.
@endophage I had the other one drilled into me. :) I don't feel particularly strongly. This is fine too. We can also do:
if r != "" {
...
}
if pageSize == 0 {
pageSize = notary.DefaultPageSize
}
(moves the extra check for outside of the if r != "" block)
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
endophage
force-pushed
the
default_records
branch
from
a10871c to
67935c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Lawrence [email protected] (github: endophage)