Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in core changes #105

Merged
merged 2 commits into from
Jul 26, 2024
Merged

error in core changes #105

merged 2 commits into from
Jul 26, 2024

Conversation

knickish
Copy link
Collaborator

@knickish knickish commented Jun 9, 2024

Now that error in core is stabilizing, look at simplifying the feature flags (and making them additive). CI will fail here until it finishes stabilizing, but if we wait for this feature to land it should let us simplify a lot of the code, and only gate features that really rely on std (such as hashmaps) behind a std feature flag

@knickish knickish marked this pull request as draft June 9, 2024 19:09
@knickish
Copy link
Collaborator Author

knickish commented Jul 16, 2024

Looks like this made it in to the 1.81 milestone, so hopefully can merge this after 2024-09-05 when 1.81 is released

@knickish
Copy link
Collaborator Author

There are a lot of changes on master that are not on a crates-io release, might make sense to just merge this and leave the nightly requirement for now

@knickish knickish marked this pull request as ready for review July 25, 2024 11:33
@knickish
Copy link
Collaborator Author

@not-fl3 Any thoughts on doing this? Can swap the no_std flag for a std flag and make it a purely additive feature. Will require nightly to use without the std feature until 1.81 releases, but we currently require nightly for no std anyway. After that rust version releases, the nightly requirement can be dropped without a breaking change

@not-fl3
Copy link
Owner

not-fl3 commented Jul 25, 2024

As long as std is on by default, nanoserde = * is the only thing required and we don't bump the minimal rust version for a std use case - I am fine with any no_std change, I do not have any strong opinions here

@knickish knickish merged commit 142d80f into not-fl3:master Jul 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants