Fixing default Cursor for x11 #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library shouldn't print anything when things are working correctly.
when XC_left_ptr is not the default System pointer. - Added XUndefineCursor to libx11.rs - Changed to calling XUndefineCursor, when calling set_cursor with CursorIcon::Default
not-fl3
reviewed
Apr 18, 2023
| }), | ||
| }; | ||
| (libx11.XDefineCursor)(display, window, cursor); | ||
| if cursor == Some(CursorIcon::Default) { |
There was a problem hiding this comment.
I understand the problem, but I do not really like the extra branching and a special case for CursorIcon::Default, can't really propose anything better right now tho, will take a closer look into it a bit later
not-fl3
force-pushed
the
master
branch
2 times, most recently
from
e50ada7
to
c9bff8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the default System cursor was changed XC_left_ptr is not the default Cursor.