General fixes with Clippy lints #315
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy lint: "mutable borrow from immutable input(s)" See https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_refclippymut_from_ref
Clippy lint: "calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing" See https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref Instead, I put display in a subscope so that the reference is dropped at the end.
`context` is already a `&mut GraphicsContext` Clippy lint: "this expression creates a reference which is immediately dereferenced by the compiler" See https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of some of the clippy lints I acted on.
Every lint I fixed is per-commit with a link attached (I think the best thing to do with this PR is a squash-merge).
The 2 first commits are clippy lints denoted as errors, all the other ones are warnings.
I didn't fix every single clippy lint, first because there are a lot of them, and second because I don't know your preferences regarding some of them (unnecessary
returnkeywords for instance, maybe you prefer that in every situation).Let me know if there should be a
clippy.tomlfile for that.