Fix issues with Atlas leaking memory. #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profan
force-pushed
the
fix/atlas-memory-leak
branch
from
48879c3
to
de8d45e
Compare
|
Made it private instead, no need to expose more API surface just to fix a leak. |
* Fix issue with Font Atlas leaking memory by adding a drop impl, reported in issue not-fl3#627
profan
force-pushed
the
fix/atlas-memory-leak
branch
from
de8d45e
to
15343ad
Compare
not-fl3
reviewed
May 3, 2024
src/text/atlas.rs
Outdated
| @@ -184,4 +190,8 @@ impl Atlas { | |||
| ); | |||
| } | |||
| } | |||
| fn delete(&mut self) { | |||
| let ctx = &mut get_context().quad_context; | |||
| ctx.delete_texture(self.texture); | |||
There was a problem hiding this comment.
I believe we used to have delete on everything, but now, with Drop, should it really be a separate function, not just drop?
There was a problem hiding this comment.
Yeah that's fair, it's probably an entirely unnecessary convention to follow now, I'll remove the delete function and just have the Drop impl :)
.. Deleted the delete function :D
|
Thanks for PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split this out from the other PR so at least this change would go in, since it seems mostly unproblematic :)