Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates note1 #1586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vitorpamplona
Copy link
Collaborator

No one should be using note1 bech addresses for anything.

Copy link
Member

@pablof7z pablof7z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%

@arthurfranca
Copy link
Contributor

Agree, there is no pubkey hint nor relay hint.

@staab
Copy link
Member

staab commented Nov 19, 2024

I agree with this, but I have a lingering doubt. note1 entities are the same as npubs, in that they're referentially transparent in a way nprofiles and nevents aren't. People use npubs all the time to identify their accounts. Identifying events in a human friendly way is less common, but could still be useful. I do think this is a net improvement though, because embedded note1s are evil. I would actually like to see nevent go away too in fact in favor of naddr, because the don't include a pubkey, which long term is going to be a more durable hint than a relay url.

Edit: forgot that nevents can have pubkeys. Ignore that part of my comment.

@alexgleason
Copy link
Member

note1 is necessary as the canonical ID of events in systems where URIs are used, eg ActivityPub bridged to Nostr.

This is because a stable identifier is needed, and it has to be a URI.

@vitorpamplona
Copy link
Collaborator Author

You can keep using it internally (I also have other nostr URIs that I use). I just don't think it needs to be an interoperable standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants