node / node-sass / CircleCI updates & fixes

[virtuoushub]

Closes:

• Cannot install nes.css with latest node versions #414
• fix: update node-sass to support node 13 #415

Description
Allows for building of project in Node 10, 12, 13, and 14.
Does builds (and more) for each runtime in CircleCI.
See: https://circleci.com/blog/circleci-matrix-jobs/

Compatibility
Improves compatibility with Node 13 and 14.

edit: Looks like this CircleCI change will not work with this repo's current checks in GitHub as they need to be explicitly "ci/circleci: build" and "ci/circleci: lint". The matrix jobs now make one build/lint per Node runtime (e.g. "ci/circleci: build-10.20.1", "ci/circleci: lint-10.20.1" ), so that would need to be changed.

Caveats
The CircleCI config could probably be cleaned up.

[doliG]

Very nice one, thank you 👍

[trezy]

LGTM 👍

[guastallaigor]

Not sure what do to here, looks like the builds are stucked, and because of that I can't merge 😢

[virtuoushub]

@guastallaigor see my comment

Looks like this CircleCI change will not work with this repo's current checks in GitHub as they need to be explicitly "ci/circleci: build" and "ci/circleci: lint".

I'd imagine changing some configuration on this repo's checks will fix it, see also: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks

[guastallaigor]

@virtuoushub I see, I've tried to change inside the Circle CI settings, but unfortunately I don't have access to it, and I didn't find it anywhere else as of this moment.

[virtuoushub]

@guastallaigor if you are an admin of this repository this should be a direct link to where you can turn on/off checks: https://github.com/nostalgic-css/NES.css/settings/branch_protection_rules/new if that link didn't work here is what GitHub's GUI looks like, which should be similar for this repo:

If you are not an admin, we will need one to help us; or I will need to refactor this PR to somehow have those checks as well.

@BcRikko / @trezy are you able to assist?

[guastallaigor]

@virtuoushub I'm not a admin of this repository, for me the Settings tab do not exist.

I think it's too much checks to run for every PR, if possible it's better if we found a way to decrease them.

[virtuoushub]

@guastallaigor while I agree the CircleCI config can be cleaned up, part of the point of this PR was to prove that the project can be built/used in multiple versions of Node. A lot of the checks happen in parallel so I do not think they are actually too many.

Having the CI build with various versions of node might help prevent future issues like:

• yarn upgrade fails #392
• Cannot install nes.css with latest node versions #414

Of the multiple checks per node version currently happening, I think the only one that does not need to happen in every version of node is the lint. I will work on making that one happen only once.

[guastallaigor]

I understand, regardless I can only merge once all the checks that we have right now were successful.

You don't need to go out of your way to make this work, we can also wait for the other members that have admin access to the repo to remove the checks, but it can take a while.

[guastallaigor]

I don't know much about Circle CI configuration stuff, but I see that all the checks were a success, and looked into them inside Circle CI.
Also this PR is going to fix the node-sass problem as well.
So LGTM 👍

[guastallaigor]

Thank you so much @virtuoushub and @SecretBase for your hard work 🎉
I couldn't have it done better myself for sure.